Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(codedeploy): Invalid yum package name still causing command failures. Better failure output also needed #13755

Closed
ProficientBell opened this issue Mar 23, 2021 · 3 comments · Fixed by #13758
Assignees
Labels
@aws-cdk/aws-codedeploy Related to AWS CodeDeploy bug This issue is a bug. needs-triage This issue or PR still needs to be triaged.

Comments

@ProficientBell
Copy link

The fix for issue #13654 isn't working for me. Here's the output I have when setting -x

  • AWS_CLI_PACKAGE_NAME=awscli
  • [[ /usr/bin/yum = \y\u\m ]]
  • /usr/bin/yum install -y awscli

This is just testing using image created with
new AmazonLinuxImage({ generation: AmazonLinuxGeneration.AMAZON_LINUX, edition: AmazonLinuxEdition.STANDARD, virtualization: AmazonLinuxVirt.HVM, storage: AmazonLinuxStorage.GENERAL_PURPOSE, });

I've worked around it by setting installAgent to false and setting up my own user data

I'm not very handy with shell scripts but it seems like this one could also do with some better error handling and reporting on issues as it takes some digging to figure out why a simple property flag with stability set as stable is failing.

Environment

  • CDK CLI Version : 1.94.1
  • Framework Version:
  • Node.js Version: 12
  • Language (Version): TypeScript

Other


This is 🐛 Bug Report

@ProficientBell ProficientBell added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Mar 23, 2021
@github-actions github-actions bot added the @aws-cdk/aws-codedeploy Related to AWS CodeDeploy label Mar 23, 2021
@mvinii94
Copy link

mvinii94 commented Mar 23, 2021

This looks like to be the culprit.

'PKG=CMD=yum'

instead of

'PKG_CMD=yum'

@skinny85
Copy link
Contributor

Yep. I'm working on a PR fixing it right now.

skinny85 added a commit to skinny85/aws-cdk that referenced this issue Mar 23, 2021
There is a typo in the UserData script that install the CodeDeploy Agent
on EC2 instances for the server DeploymentGroup.

Fixes aws#13755
@mergify mergify bot closed this as completed in #13758 Mar 25, 2021
mergify bot pushed a commit that referenced this issue Mar 25, 2021
There is a typo in the UserData script that install the CodeDeploy Agent
on EC2 instances for the server DeploymentGroup.

Fixes #13755

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

corrjo pushed a commit to corrjo/aws-cdk that referenced this issue Mar 25, 2021
There is a typo in the UserData script that install the CodeDeploy Agent
on EC2 instances for the server DeploymentGroup.

Fixes aws#13755

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

version
hollanddd pushed a commit to hollanddd/aws-cdk that referenced this issue Mar 31, 2021
There is a typo in the UserData script that install the CodeDeploy Agent
on EC2 instances for the server DeploymentGroup.

Fixes aws#13755

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
hollanddd pushed a commit to hollanddd/aws-cdk that referenced this issue Aug 26, 2021
There is a typo in the UserData script that install the CodeDeploy Agent
on EC2 instances for the server DeploymentGroup.

Fixes aws#13755

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-codedeploy Related to AWS CodeDeploy bug This issue is a bug. needs-triage This issue or PR still needs to be triaged.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants