Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(elasticsearch): 'r6gd' not marked as supported type for instance storage #14894

Merged
merged 6 commits into from
Jun 1, 2021

Conversation

ofirnk
Copy link
Contributor

@ofirnk ofirnk commented May 27, 2021

According to https://aws.amazon.com/elasticsearch-service/pricing/ it's now supported .

Fixes #14773


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented May 27, 2021

@mergify
Copy link
Contributor

mergify bot commented May 27, 2021

Title does not follow the guidelines of Conventional Commits. Please adjust title before merge.

@ofirnk ofirnk changed the title Add 'r6gd' as supported type for instance storage fix: Add 'r6gd' as supported type for instance storage May 27, 2021
@ofirnk
Copy link
Contributor Author

ofirnk commented May 27, 2021

@iliapolo Checks are green ✔️

Copy link
Contributor

@BenChaimberg BenChaimberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add to the assertion on line 1457 that R6GD instance types do not support EBS (from https://docs.aws.amazon.com/elasticsearch-service/latest/developerguide/aes-supported-instance-types.html)

@BenChaimberg BenChaimberg changed the title fix: Add 'r6gd' as supported type for instance storage fix(elasticsearch): Add 'r6gd' as supported type for instance storage May 28, 2021
@mergify mergify bot dismissed BenChaimberg’s stale review May 30, 2021 07:05

Pull request has been modified.

@ofirnk
Copy link
Contributor Author

ofirnk commented May 30, 2021

Validate PR ci looks lost in cloud space.. any way to rerun it?

@ofirnk
Copy link
Contributor Author

ofirnk commented May 31, 2021

Merge?

@BenChaimberg BenChaimberg changed the title fix(elasticsearch): Add 'r6gd' as supported type for instance storage fix(elasticsearch): 'r6gd' not marked as supported type for instance storage Jun 1, 2021
@BenChaimberg BenChaimberg self-requested a review June 1, 2021 14:55
@mergify
Copy link
Contributor

mergify bot commented Jun 1, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: bc57d5c
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit d07a49f into aws:master Jun 1, 2021
@mergify
Copy link
Contributor

mergify bot commented Jun 1, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@ofirnk ofirnk deleted the patch-1 branch June 1, 2021 18:51
hollanddd pushed a commit to hollanddd/aws-cdk that referenced this pull request Aug 26, 2021
…storage (aws#14894)

According to https://aws.amazon.com/elasticsearch-service/pricing/ it's now supported .

Fixes aws#14773


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(aws-elasticsearch): Can't set up r6gd with instance type storage
3 participants