-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(aws-cognito): SES region validity check is out of date #17795
Comments
@corymhall |
@corymhall Those docs must be outdated then. Overriding |
@straygar ah yeah looks like the docs are not up to date. Thanks for reporting this! I think your suggestion is probably the way to go, just remove the check altogether and allow CloudFormation to fail if it is not configured correctly. |
When configuring the Cognito SES email integration we were performing a region check to make sure you were configuring SES in one of the 3 supported regions. This was based on the Cognito documentation [here](https://docs.aws.amazon.com/cognito/latest/developerguide/user-pool-email.html#user-pool-email-developer) which is not correct. This PR removes that check allowing CloudFormation to provide the validation. If a user provides an incorrect region the CloudFormation deployment will fail with a descriptive error message. fixes #17795 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
|
When configuring the Cognito SES email integration we were performing a region check to make sure you were configuring SES in one of the 3 supported regions. This was based on the Cognito documentation [here](https://docs.aws.amazon.com/cognito/latest/developerguide/user-pool-email.html#user-pool-email-developer) which is not correct. This PR removes that check allowing CloudFormation to provide the validation. If a user provides an incorrect region the CloudFormation deployment will fail with a descriptive error message. fixes aws#17795 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
What is the problem?
It appears that there is a list of SES supported regions in code, and this list has become out of date.
Reproduction Steps
UserPool
ineu-north-1
with an SES email config:What did you expect to happen?
The template synthesizes as expected, as SES is available in
eu-north-1
What actually happened?
The following error is produced:
CDK CLI Version
1.134.0
Framework Version
No response
Node.js Version
v14.18.1
OS
MacOS
Language
Typescript
Language Version
No response
Other information
Maybe we could remove this check entirely, and let it fail when deploying the CFN stack, if the SES region does not exist, to keep things more maintainable?
The text was updated successfully, but these errors were encountered: