-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow customizing role session name #21012
Comments
Does this has to be behind a feature flag? |
@daschaa No, setting the environment variable or command line argument or whatever that specifies the custom role session name will suffice for the opt-in. If that is not set then it should continue to work the way it does today. |
@rittneje Yes that is true, we just have to make sure that the environment variable is not set in some CI/CD pipeline by mistake. Do you have an idea how the environment variable could be named 🤔 |
@daschaa I think something simple like |
Would love to see this feature, it's a bummer the linked PR wasn't able to be merged |
Describe the feature
When CDK automatically assumes a role (such as cdk-hnb659fds-deploy-role), currently it hard-codes the role session name to be "aws-cdk-<username>". This is not particularly useful for auditing when deployments are made via a CICD pipeline.
aws-cdk/packages/aws-cdk/lib/api/aws-auth/sdk-provider.ts
Line 348 in 400ad91
Instead, it should allow specifying the role session name, either through a command line flag or through an environment variable.
Use Case
See above.
Proposed Solution
No response
Other Information
No response
Acknowledgements
CDK version used
2.28.0 (build ba233f0)
Environment details (OS name and version, etc.)
Alpine 3.16, Python 3.10.5
The text was updated successfully, but these errors were encountered: