Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

route53: Cname domainName vs recordName ambiguous #25552

Closed
mdavis-xyz opened this issue May 12, 2023 · 3 comments · Fixed by #25579
Closed

route53: Cname domainName vs recordName ambiguous #25552

mdavis-xyz opened this issue May 12, 2023 · 3 comments · Fixed by #25579
Labels
@aws-cdk/aws-route53 Related to Amazon Route 53 documentation This is a problem with documentation. effort/small Small work item – less than a day of effort p2

Comments

@mdavis-xyz
Copy link

mdavis-xyz commented May 12, 2023

Describe the issue

For route53.CnameRecord, the argument domainName has definition:

The domain name.

The argument recordName has definition:

The domain name for this record.

That's the same definition. It's not clear which is which.
The only difference is "for this record", but both the target and the alias domain names are associated with this record.
And I expect both of those to be required.

Even once I figure out which argument is which, it's still ambiguous whether I need to pass "myhost" or "myhost.mydomain.com" (i.e. myhost.${zone.zoneName}).

After trying a few things, I think I've figured out the behavior.
I think domainName should be defined as:

The domain name of the target that this record points to.

(Or to align with the service's terminology, we can call this the "value".)

and recordName should be redefined as

The subdomain name that for this record, which is for the domain that DNS clients will submit the query against.

Links

https://docs.aws.amazon.com/cdk/api/v2/docs/aws-cdk-lib.aws_route53.CnameRecord.html

@mdavis-xyz mdavis-xyz added documentation This is a problem with documentation. needs-triage This issue or PR still needs to be triaged. labels May 12, 2023
@github-actions github-actions bot added the @aws-cdk/aws-route53 Related to Amazon Route 53 label May 12, 2023
@pahud
Copy link
Contributor

pahud commented May 12, 2023

Yes this is very ambiguous now and we should improve the construct doc. Are you interested to submit a PR for that?

@pahud pahud added p2 effort/small Small work item – less than a day of effort and removed needs-triage This issue or PR still needs to be triaged. labels May 12, 2023
@mergify mergify bot closed this as completed in #25579 May 15, 2023
mergify bot pushed a commit that referenced this issue May 15, 2023
…roperty (#25579)

Closes #25552.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@savanthongvanh
Copy link

this was a nice change. @mdavis-xyz isn't the hostedzone and domain name redundant here? or is there another clarification that might help about how the domain name should or shouldn't match the hosted zone?

isnt the domain name just the zone name of the hosted zone?

thanks in advance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-route53 Related to Amazon Route 53 documentation This is a problem with documentation. effort/small Small work item – less than a day of effort p2
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants