Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws-apprunner-alpha: serviceName return service ARN instead name #26002

Closed
sonit1810 opened this issue Jun 16, 2023 · 2 comments · Fixed by #26015
Closed

aws-apprunner-alpha: serviceName return service ARN instead name #26002

sonit1810 opened this issue Jun 16, 2023 · 2 comments · Fixed by #26015
Labels
@aws-cdk/aws-apprunner Related to the apprunner package bug This issue is a bug. effort/small Small work item – less than a day of effort p1

Comments

@sonit1810
Copy link

Describe the bug

After i create App Runner service using new apprunner.Service

I export service name by

new cdk.CfnOutput(this, 'AppRunnerServiceName', {
            value: service.serviceName ,
            exportName: 'service-name'
        });

Some how it exported the Service ARN, not the Service Name

Expected Behavior

Service Name exported.

Current Behavior

Service ARN exported

Reproduction Steps

Create App Runner service using const service = new apprunner.Service``

Then try export service.serviceName

It will return Service ARN of App Runner Instance, not the Service Name.

Possible Solution

No response

Additional Information/Context

No response

CDK CLI Version

2.81.0-alpha.0

Framework Version

2.81.0-alpha.0

Node.js Version

20

OS

Ubuntu

Language

Typescript

Language Version

4.9.5

Other information

No response

@sonit1810 sonit1810 added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Jun 16, 2023
@github-actions github-actions bot added the @aws-cdk/aws-apprunner Related to the apprunner package label Jun 16, 2023
@pahud pahud added p1 effort/small Small work item – less than a day of effort and removed needs-triage This issue or PR still needs to be triaged. labels Jun 16, 2023
@mergify mergify bot closed this as completed in #26015 Jun 20, 2023
mergify bot pushed a commit that referenced this issue Jun 20, 2023
The AppRunner `Service` L2 construct returns `serviceArn` attribute as the `serviceName`. As Cloudformation does not return serivceName attribute(see [return values](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-apprunner-service.html#aws-resource-apprunner-service-return-values)). This PR splits the serviceArn to extract the serviceName instead.

Closes #26002 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-apprunner Related to the apprunner package bug This issue is a bug. effort/small Small work item – less than a day of effort p1
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants