Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pipelines): codeStar connection accepts nested repository #29631

Merged
merged 8 commits into from
Apr 1, 2024

Conversation

yynakanoyy
Copy link
Contributor

@yynakanoyy yynakanoyy commented Mar 27, 2024

Issue # (if applicable)

Closes #27504

Reason for this change

The current validation of repoString in constructor of CodeStarConnectionSource does not support nested repository that can appear in GitLab.

Description of changes

The validation is fixed to accept nested repository.

Description of how you validated changes

I added unit tests and confirmed all tests passed.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK label Mar 27, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team March 27, 2024 16:17
@github-actions github-actions bot added bug This issue is a bug. effort/small Small work item – less than a day of effort p1 labels Mar 27, 2024
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@yynakanoyy yynakanoyy changed the title fix(pipelines): CodeStar connection accepts nested repository fix(pipelines): codeStar connection accepts nested repository Mar 27, 2024
@yynakanoyy
Copy link
Contributor Author

Exemption Request: integrations test needs CodeStar connection but it is not feasible to create actual connection during the test.

@aws-cdk-automation aws-cdk-automation added pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. pr/needs-maintainer-review This PR needs a review from a Core Team Member labels Mar 27, 2024
Copy link
Contributor

@aaythapa aaythapa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making this change!

@aaythapa
Copy link
Contributor

Exemption Request: integrations test needs CodeStar connection but it is not feasible to create actual connection during the test.

Not too familiar with CodeStar so I'll double check with the team to validate this before granting exemption. Doing a search through our integ tests I do see CodeStarConnectionsSourceAction in this test, again not too familiar and didn't look too deep but is that test helpful in creating an integ test for this change?

@aaythapa
Copy link
Contributor

Hi again, chatted with the team and an integ test with a resource that deploys should be enough, don't need to make a request. You can use the template thats defined in the original issue as a starter. Also, you can look through this doc if you're unfamiliar with CDK integ tests.

@aws-cdk-automation aws-cdk-automation dismissed their stale review March 29, 2024 06:57

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@yynakanoyy
Copy link
Contributor Author

Hi again, chatted with the team and an integ test with a resource that deploys should be enough, don't need to make a request. You can use the template thats defined in the original issue as a starter. Also, you can look through this doc if you're unfamiliar with CDK integ tests.

I have added an integ test. Please correct me if the test does not make sense.

@yynakanoyy
Copy link
Contributor Author

Exemption Request: integrations test needs CodeStar connection but it is not feasible to create actual connection during the test.

I would like to cancel the request as an integ test has been added.

This was referenced Apr 1, 2024
aaythapa
aaythapa previously approved these changes Apr 1, 2024
Copy link
Contributor

mergify bot commented Apr 1, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot dismissed aaythapa’s stale review April 1, 2024 21:36

Pull request has been modified.

Copy link
Contributor

mergify bot commented Apr 1, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 2070388
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 10357c0 into aws:main Apr 1, 2024
9 checks passed
Copy link
Contributor

mergify bot commented Apr 1, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.

@aws aws locked as resolved and limited conversation to collaborators Jul 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK bug This issue is a bug. effort/small Small work item – less than a day of effort p1 pr/needs-maintainer-review This PR needs a review from a Core Team Member pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pipelines: unable to reference GitLab repositories nested under a group with CodePipelieneSource.connection
3 participants