-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(integ-tests): httpApiCall.expect
with resolved URL
#29705
fix(integ-tests): httpApiCall.expect
with resolved URL
#29705
Conversation
packages/@aws-cdk/integ-tests-alpha/test/assertions/providers/integ.http-api-call-assertions.ts
Outdated
Show resolved
Hide resolved
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one. |
Issue # (if applicable)
Closes #29700
I've also opened #29701 to catch similar issues at synth time in the future
Reason for this change
When running
httpApiCall('url').expect
, theAssertionResults
output logical ID would be overridden with an invalid name, containing the URL slashes.This issue was not noticed earlier because, as far as I can tell, assertions were only made with
Token
/Ref
URLs, e.g.apigw.DomainName
Description of changes
AssertionResults
output logical IDExpectedResult
, I noticed it was slightly lacking while creating the integration testDescription of how you validated changes
I've added unit and integration tests. The integration tests include both tests with API Gateway, to cover unresolved URLs, and to https://httpbin.org/ to test this fix
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license