Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revert: "chore(ec2): update WindowsVersions enum" #29737

Merged
merged 5 commits into from
Apr 9, 2024
Merged

revert: "chore(ec2): update WindowsVersions enum" #29737

merged 5 commits into from
Apr 9, 2024

Conversation

scanlonp
Copy link
Contributor

@scanlonp scanlonp commented Apr 5, 2024

Reverts #29435

Closes #29736. See for more details.

@aws-cdk-automation aws-cdk-automation requested a review from a team April 5, 2024 01:42
@github-actions github-actions bot added bug This issue is a bug. p1 labels Apr 5, 2024
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Apr 5, 2024
@scanlonp scanlonp mentioned this pull request Apr 5, 2024
Merged
1 task
@scanlonp scanlonp added the pr/do-not-merge This PR should not be merged at this time. label Apr 8, 2024
@github-actions github-actions bot mentioned this pull request Apr 8, 2024
Closed
@scanlonp
Copy link
Contributor Author

scanlonp commented Apr 8, 2024

@Mergifyio update

@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 8, 2024

update

✅ Branch has been successfully updated

@nmussy nmussy mentioned this pull request Apr 9, 2024
Closed
1 task
@scanlonp scanlonp removed the pr/do-not-merge This PR should not be merged at this time. label Apr 9, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 9, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 9a37485
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit ccc63cf into main Apr 9, 2024
12 checks passed
@mergify mergify bot deleted the revert-29435-chore-ec2-windows-versions branch April 9, 2024 18:56
@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 9, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

scanlonp added a commit that referenced this pull request Apr 9, 2024
@scanlonp
revert: "chore(ec2): update WindowsVersions enum" (#29737)
0e9d5ca 
Reverts #29435

Closes #29736. See for more details.
@github-actions github-actions bot mentioned this pull request May 1, 2024
Closed
This was referenced May 23, 2024
Open
Open
@rwlxxvii rwlxxvii mentioned this pull request May 27, 2024
Merged
@NOUIY NOUIY mentioned this pull request May 30, 2024
Open
@NOUIY NOUIY mentioned this pull request Jun 7, 2024
Open
@niravparikh05 niravparikh05 mentioned this pull request Jun 13, 2024
Open
@NOUIY NOUIY mentioned this pull request Jun 14, 2024
Open
@aws-cdk-automation
Copy link
Collaborator

Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.

@aws aws locked as resolved and limited conversation to collaborators Jul 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@comcalvi comcalvi comcalvi approved these changes

@SankyRed SankyRed SankyRed approved these changes

Assignees
No one assigned
Labels
bug This issue is a bug. contribution/core This is a PR that came from AWS. p1
Projects
None yet
Milestone
No milestone
4 participants
@scanlonp @aws-cdk-automation @comcalvi @SankyRed