-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(cli): cdk diff --template
>=2.133.0 crashes
#29890
Closed
toha-nordic opened this issue
Apr 18, 2024
· 2 comments
· Fixed by #29896, rwlxxvii/containers#124 or rwlxxvii/containers#140 · May be fixed by NOUIY/aws-solutions-constructs#98 or NOUIY/aws-solutions-constructs#99
Closed
(cli): cdk diff --template
>=2.133.0 crashes
#29890
toha-nordic opened this issue
Apr 18, 2024
· 2 comments
· Fixed by #29896, rwlxxvii/containers#124 or rwlxxvii/containers#140 · May be fixed by NOUIY/aws-solutions-constructs#98 or NOUIY/aws-solutions-constructs#99
Labels
bug
This issue is a bug.
cli
Issues related to the CDK CLI
effort/medium
Medium work item – several days of effort
p1
package/tools
Related to AWS CDK Tools or CLI
Comments
toha-nordic
added
bug
This issue is a bug.
needs-triage
This issue or PR still needs to be triaged.
labels
Apr 18, 2024
pahud
added
cli
Issues related to the CDK CLI
p1
effort/medium
Medium work item – several days of effort
and removed
needs-triage
This issue or PR still needs to be triaged.
labels
Apr 18, 2024
This was referenced Apr 22, 2024
mergify bot
pushed a commit
that referenced
this issue
Apr 24, 2024
### Issue # (if applicable) Closes #29890. ### Reason for this change `cdk diff` crashes with `--template`. ### Description of changes The addition of changeset logic had a leftover refactor that should not have been leftover (trying to pass a template directly instead of a stack artifact). Removes changeset creation code from fixed template mode, which should never create a changeset, and adds a unit test for fixed template diffs so we don't break this in the future. ### Description of how you validated changes unit tests + manual testing. CLI integ tests will be added in a follow-up PR. ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
|
This was referenced May 23, 2024
This was referenced Jun 22, 2024
Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
bug
This issue is a bug.
cli
Issues related to the CDK CLI
effort/medium
Medium work item – several days of effort
p1
package/tools
Related to AWS CDK Tools or CLI
Describe the bug
When using
--template
withcdk diff
it crashes with CDK >=2.133.0 (tested up to 2.137.0):Expected Behavior
With CDK
2.132.0
it still works as before:Current Behavior
Notice if
--template
flag is removed, it works fine:Reproduction Steps
backend-cd
into CFN with CDKtmp/
cdk.out
:cdk synth -a 'dist/aws/cloudformation-cd.js'
--no-change-set
doesnt help):Possible Solution
No response
Additional Information/Context
Logs of a working run with
v2.132.0
:CDK CLI Version
2.133.0 (build dcc1e75)
Framework Version
No response
Node.js Version
v18.19.1
OS
Ubuntu 22.04.4 LTS
Language
TypeScript
Language Version
4.7.3
Other information
Looking at commits between 2.132.0 and 2.133.0 there were at least two PRs merged related to diffing but Im not competent on CDK to understand if they could be related: https://github.com/aws/aws-cdk/commits/main/?since=2024-03-09&until=2024-03-15
The text was updated successfully, but these errors were encountered: