-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Property 'assetParameters' implicitly has type 'any'" error #5497
Comments
I don't have much typescript experience, would it be reasonable to add a dependency to the core module for typescript ^3.7? That way at least builds would throw an error if they're on the wrong version |
The thing is, you can also work around it by changing |
@skinny85 fair enough. Is there any better way of letting users know they should double check for this? Maybe in the release notes? We've stumbled into it in two projects so far. |
Not really :( unfortunately, we missed this change when we released it, that's why it's not in the release notes, and hence this pinned issue. |
I had a similar error |
This issue has not received any attention in 1 year. If you want to keep this issue open, please leave a comment below and auto-close will be canceled. |
Typescript 3.6 had a bug where the
noImplicitAny
check would incorrectly be performed on private ambient private getters (such asassetParameters()
).This was tracked by our jsii issue #994, and resolved in Typescript PR #33896.
This issue no longer exists in Typescript >3.7.
However, for users using both Typescript <3.7 who have
noImplicitAny: true
in theirtsconfig.json
file (set to true in CDK 1.19.0),npm run build
will result in the error:This can be resolved by updating the typescript dependency to >=3.7 OR through either of the following workarounds in the
tsconfig.json
file:noImplicitAny: true, => noImplicitAny: false,
OR
+ skipLibCheck: true,
The text was updated successfully, but these errors were encountered: