Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CodeBuild "LINUX_GPU_CONTAINER" environment type #8408

Closed
2 tasks
ajaykarpur opened this issue Jun 5, 2020 · 1 comment · Fixed by #8879
Closed
2 tasks

CodeBuild "LINUX_GPU_CONTAINER" environment type #8408

ajaykarpur opened this issue Jun 5, 2020 · 1 comment · Fixed by #8879
Assignees
@skinny85
Labels
@aws-cdk/aws-codebuild Related to AWS CodeBuild effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. in-progress This issue is being actively worked on.

Comments

@ajaykarpur
Copy link

ajaykarpur commented Jun 5, 2020 •
edited
Loading

The CodeBuild documentation indicates that there is support for builds running in a GPU container with the environment type LINUX_GPU_CONTAINER. Support for this should be added to the CDK.

Use Case

Some of our tests require a GPU environment to run. Currently, we accomplish this using Amazon Deep Learning AMIs on an EC2 instance, but the DLAMIs are out of date and don't support Python 3.7, which we now need to run our tests. We thought that we'd be able to switch to CodeBuild for these GPU tests, but it looks like the GPU environment type isn't yet supported by the CDK.

Proposed Solution

Analogous to eg. codebuild.ComputeType.LARGE, there could be a value like codebuild.EnvironmentType.LINUX_GPU_CONTAINER.

Other

Links for context:

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change

This is a 🚀 Feature Request
@ajaykarpur ajaykarpur added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Jun 5, 2020
@skinny85
Copy link
Contributor

skinny85 commented Jun 8, 2020

Hey @ajaykarpur ,

thanks for opening the issue. The problem here is not adding something to ComputeType, but adding a new Image class, similarly like we did for ARM_CONTAINER in #5541.

Is there any chance you could submit us a PR with this change?

Thanks,
Adam

@skinny85 skinny85 added effort/small Small work item – less than a day of effort and removed needs-triage This issue or PR still needs to be triaged. labels Jun 8, 2020
@SomayaB SomayaB added the @aws-cdk/aws-codebuild Related to AWS CodeBuild label Jun 8, 2020
@ajaykarpur ajaykarpur mentioned this issue Jun 8, 2020
Closed
@skinny85 skinny85 mentioned this issue Jul 2, 2020
Merged
@SomayaB SomayaB added the in-progress This issue is being actively worked on. label Jul 7, 2020
@ermanno ermanno mentioned this issue Aug 6, 2020
Closed
2 tasks
@mergify mergify bot closed this as completed in #8879 Aug 12, 2020
mergify bot pushed a commit that referenced this issue Aug 12, 2020
@skinny85
feat(codebuild): add support for GPU build images (#8879)
b1b4cee 
CodeBuild has added support for running builds on machines with GPU drivers.
This required some changes to the protocol between `IBuildImage` and `Project`,
as those images are hosted in a public ECR repository that the image must grant the Project's Role access to.
Introduced a `bind()` method to `IBuildImage` -
to maintain backwards comaptibility,
made it optional.

Fixes #8408 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skinny85 skinny85

Labels
@aws-cdk/aws-codebuild Related to AWS CodeBuild effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. in-progress This issue is being actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(codebuild): add support for GPU build images skinny85/aws-cdk
3 participants
@skinny85 @ajaykarpur @SomayaB