[codepipeline-actions] max-age header not set correctly for s3 deploy action

[nonken]

The Cache-Control max-age key value gets set wrongly when using an S3DeploymentAction.

Current max-age: Number
Expected max-age=Number

Thanks to the excellent and super fast triage from @mikesherov 🙏.

https://twitter.com/mikesherov/status/1277320422791528457

The faulty line can be found here:

aws-cdk/packages/@aws-cdk/aws-codepipeline-actions/lib/s3/deploy-action.ts

Line 33 in 8d5b801

public static maxAge(t: Duration) { return new CacheControl(`max-age: ${t.toSeconds()}`); }

The same applies for the s-maxage property:

aws-cdk/packages/@aws-cdk/aws-codepipeline-actions/lib/s3/deploy-action.ts

Line 35 in 8d5b801

public static sMaxAge(t: Duration) { return new CacheControl(`s-maxage: ${t.toSeconds()}`); }

Also see here https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Cache-Control

Reproduction Steps

new S3DeployAction({
  cacheControl: [CacheControl.maxAge(Duration.days(365))]
});

Environment

• CLI Version : 1.47.0
• Framework Version:
• Node.js Version:
• OS :
• Language (Version):

Other

---

This is 🐛 Bug Report

[skinny85]

Thanks for opening the issue @nonken !

Any chance you can open us a PR fixing this? https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md#getting-started 😃

[nonken]

@skinny85 I should be able to get to this sometime this week yep. Especially for a former colleague 🤗

[nonken]

@skinny85 I have opened a PR, would be amazing if this can go in as it is breaking the interwebs 😄

[skinny85]

@skinny85 I have opened a PR, would be amazing if this can go in as it is breaking the interwebs 😄

Approved - I don't want to keep the interwebs waiting! 😅

Thanks so much for taking care of this issue @nonken !

[nonken]

🤗 Wohoo!!