Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate OracleSE and OracleSE1 engines after RDS blocks creating new instances (August 2020) #9249

Closed
6 tasks
skinny85 opened this issue Jul 24, 2020 · 0 comments · Fixed by #10241
Closed
6 tasks

Deprecate OracleSE and OracleSE1 engines after RDS blocks creating new instances (August 2020) #9249

skinny85 opened this issue Jul 24, 2020 · 0 comments · Fixed by #10241
Assignees
@njlynch
Labels
@aws-cdk/aws-rds Related to Amazon Relational Database effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. in-progress This issue is being actively worked on. p2
Milestone
[GA] RDS

Comments

@skinny85
Copy link
Contributor

skinny85 commented Jul 24, 2020 •
edited
Loading

See: #9016 (comment)

We need to:

  • Deprecate the oracleSe and oracleSe1 methods on DatabaseInstanceEngine
  • Deprecate the OracleSeInstanceEngineProps and OracleSe1InstanceEngineProps structs
  • Deprecate the OracleLegacyEngineVersion class
  • Change the deprecation messages on the ORACLE_SE and ORACLE_SE1 constants in DatabaseInstanceEngine
  • Remove all references to Oracle SE and Oracle SE1 from the ReadMe of the RDS package
  • Change the integ.instance.lit.ts integ test to use Oracle SE2 instead of SE1 (as it will no longer deploy soon)
@skinny85 skinny85 added this to the RDS to 'stable' milestone Jul 24, 2020
@skinny85 skinny85 self-assigned this Jul 24, 2020
@skinny85 skinny85 added @aws-cdk/aws-rds Related to Amazon Relational Database effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2 labels Jul 24, 2020
njlynch added a commit that referenced this issue Sep 8, 2020
@njlynch
feat(rds): deprecate OracleSE and OracleSE1 engine versions
7a0b443 
Oracle 11.x and the SE and SE1 engines are no longer supported by Oracle
(and RDS). As of Sep 1, 2020, no new instances can be launched with these
engines (with the license-included license type). Support for
bring-your-own-license instances will be removed Oct 1.

See https://forums.aws.amazon.com/ann.jspa?annID=7341 for more details.

fixes #9249
@njlynch njlynch assigned njlynch and unassigned skinny85 Sep 8, 2020
@njlynch njlynch mentioned this issue Sep 8, 2020
Merged
@SomayaB SomayaB added the in-progress This issue is being actively worked on. label Sep 8, 2020
@mergify mergify bot closed this as completed in #10241 Sep 9, 2020
mergify bot pushed a commit that referenced this issue Sep 9, 2020
@njlynch
feat(rds): deprecate OracleSE and OracleSE1 engine versions (#10241)
562f891 
Oracle 11.x and the SE and SE1 engines are no longer supported by Oracle
(and RDS). As of Sep 1, 2020, no new instances can be launched with these
engines (with the license-included license type). Support for
bring-your-own-license instances will be removed Oct 1.

Also took the opportunity to remove deprecated usages of version-less engines
from the README.

See https://forums.aws.amazon.com/ann.jspa?annID=7341 for more details.

fixes #9249


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@njlynch njlynch

Labels
@aws-cdk/aws-rds Related to Amazon Relational Database effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. in-progress This issue is being actively worked on. p2
Projects
None yet
Milestone
[GA] RDS
Development

Successfully merging a pull request may close this issue.

feat(rds): deprecate OracleSE and OracleSE1 engine versions aws/aws-cdk
3 participants
@skinny85 @njlynch @SomayaB