Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lambda): switch bundling images from DockerHub to ECR public gallery #13473

Merged
merged 9 commits into from Apr 1, 2021

Conversation

@pgarbe
Copy link
Contributor

@pgarbe pgarbe commented Mar 8, 2021

fixes #11296


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

@gitpod-io gitpod-io bot commented Mar 8, 2021

@MrArnoldPalmer
Copy link
Contributor

@MrArnoldPalmer MrArnoldPalmer commented Mar 9, 2021

This looks like it just needs to run integration tests for the build to pass. @pgarbe are you able to run the integ tests in aws-lambda against one of your accounts?

@nija-at do you see any downside to this for aws-lambda-(python|nodejs)?

@pgarbe
Copy link
Contributor Author

@pgarbe pgarbe commented Mar 9, 2021

I've some troubles running the integration tests. I also can't see what exactly is failing. Any hints are welcome.

@MrArnoldPalmer
Copy link
Contributor

@MrArnoldPalmer MrArnoldPalmer commented Mar 11, 2021

@pgarbe There is a comment linking to the failed build logs here. If you run yarn test from within the aws-lambda-python it should show you what parts of the stack have changed. You'll have to run yarn integ to deploy the stack changes which will also update the snapshots and allow yarn test to pass. This will deploy the test stacks to whatever account you have credentials for and then clean them up when done.

@nija-at
Copy link
Contributor

@nija-at nija-at commented Mar 17, 2021

Hello -

Sorry about the delay in reviewing PRs. We are experiencing an increased backlog of items that need our attention.
We will get to your PR as soon as we are able to. Apologies for the delay.

Copy link
Contributor

@nija-at nija-at left a comment

Thanks for submitting this PR @pgarbe.

One question below before jumping into the actual code changes.

@nija-at nija-at changed the title feat(@aws-cdk/aws-lambda): Use bundling images from ECR public gallery feat(lambda): switch bundling images from DockerHub to ECR public gallery Mar 25, 2021
@nija-at nija-at changed the title feat(lambda): switch bundling images from DockerHub to ECR public gallery feat(lambda): switch bundling images from Docker Hub to ECR public gallery Mar 25, 2021
@nija-at nija-at dismissed their stale review Mar 25, 2021

failing build

Copy link
Contributor

@nija-at nija-at left a comment

Could you look at the failing build and fix it?

@pgarbe pgarbe force-pushed the pgarbe:issue11296 branch from f411288 to cc757a4 Mar 29, 2021
@mergify mergify bot dismissed nija-at’s stale review Mar 29, 2021

Pull request has been modified.

@pgarbe
Copy link
Contributor Author

@pgarbe pgarbe commented Mar 29, 2021

@nija-at I fixed the build

@aws-cdk-automation
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation commented Apr 1, 2021

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: c7a95fb
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@nija-at nija-at changed the title feat(lambda): switch bundling images from Docker Hub to ECR public gallery feat(lambda): switch bundling images from DockerHub to ECR public gallery Apr 1, 2021
@nija-at
nija-at approved these changes Apr 1, 2021
@mergify
Copy link
Contributor

@mergify mergify bot commented Apr 1, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit e2e008b into aws:master Apr 1, 2021
9 checks passed
9 checks passed
@github-actions
auto-approve
Details
@github-actions
validate-pr
Details
@github-actions
validate-pr
Details
@github-actions
test
Details
@github-actions
test
Details
AWS CodeBuild us-east-1 (AutoBuildProject89A8053A-LhjRyN9kxr8o) Build succeeded for project AutoBuildProject89A8053A-LhjRyN9kxr8o
Details
@gitpod-io
Gitpod Open an online workspace in Gitpod
Details
@semantic-pull-requests
Semantic Pull Request ready to be squashed
Details
@mergify
Summary 5 potential rules
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

5 participants