-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(lambda): switch bundling images from DockerHub to ECR public gallery #13473
Conversation
This looks like it just needs to run integration tests for the build to pass. @pgarbe are you able to run the integ tests in aws-lambda against one of your accounts? @nija-at do you see any downside to this for aws-lambda-(python|nodejs)? |
I've some troubles running the integration tests. I also can't see what exactly is failing. Any hints are welcome. |
@pgarbe There is a comment linking to the failed build logs here. If you run |
Hello - Sorry about the delay in reviewing PRs. We are experiencing an increased backlog of items that need our attention. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for submitting this PR @pgarbe.
One question below before jumping into the actual code changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you look at the failing build and fix it?
@nija-at I fixed the build |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
fixes #11296
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license