Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lambda-event-sources): incorrect documented defaults for stream types #14562

Merged
merged 3 commits into from
May 12, 2021

Conversation

nija-at
Copy link
Contributor

@nija-at nija-at commented May 6, 2021

The defaults documented for maxRecordAge and retryAttempts
properties for event sources that are 'stream' type were documented
incorrectly.

The implementation falls back to the defaults provided by
CloudFormation.

fixes #13908


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

…ypes

The defaults documented for `maxRecordAge` and `retryAttempts`
properties for event sources that are 'stream' type were documented
incorrectly.

The implementation falls back to the defaults provided by
CloudFormation.

fixes #13908
@nija-at nija-at added the pr-linter/exempt-test The PR linter will not require test changes label May 6, 2021
@nija-at nija-at requested a review from a team May 6, 2021 13:25
@nija-at nija-at self-assigned this May 6, 2021
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label May 6, 2021
@rix0rrr rix0rrr added the pr/do-not-merge This PR should not be merged at this time. label May 10, 2021
@gitpod-io
Copy link

gitpod-io bot commented May 11, 2021

@nija-at nija-at removed the pr/do-not-merge This PR should not be merged at this time. label May 11, 2021
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 088fa3e
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 0ea24e9 into master May 12, 2021
@mergify mergify bot deleted the nija-at/fix-eventsource-defaults branch May 12, 2021 09:56
@mergify
Copy link
Contributor

mergify bot commented May 12, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

hollanddd pushed a commit to hollanddd/aws-cdk that referenced this pull request Aug 26, 2021
…ypes (aws#14562)

The defaults documented for `maxRecordAge` and `retryAttempts`
properties for event sources that are 'stream' type were documented
incorrectly.

The implementation falls back to the defaults provided by
CloudFormation.

fixes aws#13908


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-lambda-event-sources contribution/core This is a PR that came from AWS. pr-linter/exempt-test The PR linter will not require test changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws-lambda: default values discrepancies between TypeScript and Web documentation
3 participants