Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(GitHub issue templates): Upgrade to GitHub Issues v2 #16592

Merged
merged 4 commits into from
Oct 1, 2021

Conversation

ryparker
Copy link
Contributor

@ryparker ryparker commented Sep 22, 2021

Summary

This PR updates this repo's GitHub issue templates to v2. (see prototype)

Reviewers: Please make sure that all the fields i've marked with required: true are necessary. A user will not be able to create an issue without these required fields being completed.

GitHub issues v2 docs

CleanShot 2021-09-21 at 18 37 06@2x

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Sep 22, 2021

@mergify
Copy link
Contributor

mergify bot commented Sep 22, 2021

Title does not follow the guidelines of Conventional Commits. Please adjust title before merge.

@ryparker ryparker changed the title docs(.github/ISSUE_TEMPLATES) Upgrade to GitHub Issues v2 docs(.github/ISSUE_TEMPLATE) Upgrade to GitHub Issues v2 Sep 22, 2021
@ryparker ryparker added the contribution/core This is a PR that came from AWS. label Sep 22, 2021
@ryparker ryparker changed the title docs(.github/ISSUE_TEMPLATE) Upgrade to GitHub Issues v2 docs(.github/ISSUE_TEMPLATE): Upgrade to GitHub Issues v2 Sep 22, 2021
@ryparker ryparker changed the title docs(.github/ISSUE_TEMPLATE): Upgrade to GitHub Issues v2 docs(GitHub issue templates): Upgrade to GitHub Issues v2 Sep 22, 2021
@ryparker ryparker added the pr/do-not-merge This PR should not be merged at this time. label Sep 28, 2021
@ryparker
Copy link
Contributor Author

ryparker commented Sep 28, 2021

Preventing auto merge with pr/do-not-merge label so that multiple reviewers can approve/suggest changes.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: a68a396
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@ryparker ryparker removed the pr/do-not-merge This PR should not be merged at this time. label Oct 1, 2021
@mergify mergify bot merged commit 1875287 into master Oct 1, 2021
@mergify mergify bot deleted the github-issues-v2 branch October 1, 2021 19:18
@mergify
Copy link
Contributor

mergify bot commented Oct 1, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

xykkong added a commit to xykkong/aws-cdk that referenced this pull request Oct 6, 2021
* '15588' of https://github.com/xykkong/aws-cdk: (47 commits)
  chore: rollback `GenericSSMParameterImage` deprecation (backport aws#16798) (aws#16800)
  chore(deps): bump actions/setup-node from 2.4.0 to 2.4.1 (aws#16778)
  Update CHANGELOG.md
  chore(release): 1.126.0
  feat(assertions): matcher support for `templateMatches()` API (aws#16789)
  feat(stepfunctions-tasks): add step concurrency level to EmrCreateCluster (aws#15242)
  docs(s3): correct heading levels Object Ownership / Bucket deletion (aws#16790)
  chore(individual-pkg-gen): fix bug in setting alpha package visibility (aws#16787)
  fix(s3): setting `autoDeleteObjects` to `false` empties the bucket (aws#16756)
  fix(iam): `User.fromUserArn` does not work for ARNs that include a path (aws#16269)
  fix(cli): progress bar overshoots count by 1 for stack updates (aws#16168)
  fix(config): add SourceAccount condition to Lambda permission (aws#16617)
  docs(events): add a note about not using `EventPattern` with `CfnRule` (aws#16715)
  docs(core): fix reference to nonexistant enum value (aws#16716)
  chore(s3-deployments): update python version on BucketDeployment handler (aws#16771)
  chore: set response-requested length to 2 and closing-soon to 5 (aws#16763)
  fix(revert): "fix: CDK does not honor NO_PROXY settings (aws#16751)" (aws#16761)
  docs(GitHub issue templates): Upgrade to GitHub Issues v2 (aws#16592)
  chore: reset jsii-rosetta worker count to default (aws#16755)
  fix: CDK does not honor NO_PROXY settings (aws#16751)
  ...
njlynch pushed a commit that referenced this pull request Oct 11, 2021
## Summary

This PR updates this repo's GitHub issue templates to v2. ([see prototype](https://github.com/ryparker/proto-github-issues-v2/issues/new/choose)) 

**Reviewers**: Please make sure that all the fields i've marked with `required: true` are necessary. A user will not be able to create an issue without these required fields being completed.

[GitHub issues v2 docs](https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/syntax-for-issue-forms)

<kbd>

<img width="1278" alt="CleanShot 2021-09-21 at 18 37 06@2x" src="https://user-images.githubusercontent.com/17558268/134269803-f5dda15c-6bdc-4c63-ac3e-65a3f1626246.png">

</kbd>

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Feb 21, 2022
## Summary

This PR updates this repo's GitHub issue templates to v2. ([see prototype](https://github.com/ryparker/proto-github-issues-v2/issues/new/choose)) 

**Reviewers**: Please make sure that all the fields i've marked with `required: true` are necessary. A user will not be able to create an issue without these required fields being completed.

[GitHub issues v2 docs](https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/syntax-for-issue-forms)

<kbd>

<img width="1278" alt="CleanShot 2021-09-21 at 18 37 06@2x" src="https://user-images.githubusercontent.com/17558268/134269803-f5dda15c-6bdc-4c63-ac3e-65a3f1626246.png">

</kbd>

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants