fix(aws-ecs):remove restriction on network mode to support ecs-a for windows #19924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quick fix for bug: aws#19922 A longer term solution should be put together that includes updating the ExternalTaskProp structure to support network modes now that ECS-A for windows allows more than bridge
|
Title does not follow the guidelines of Conventional Commits. Please adjust title before merge. |
|
|
grollat
changed the title
splitting the if condition in 2 lines would make the code less readable just for saving 14 characters in width. worth the tradeoff
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
TheRealAmazonKendra
requested changes
Jul 14, 2022
|
|
||
| if (this.isExternalCompatible && this.networkMode !== NetworkMode.BRIDGE) { | ||
| throw new Error(`External tasks can only have Bridge network mode, got: ${this.networkMode}`); | ||
| // eslint-disable-next-line max-len |
There was a problem hiding this comment.
Rather than using this the if statement should be broken up into two lines.
|
This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week. |
|
This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error. |
aws-cdk-automation
added
the
closed-for-staleness
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
quick fix for bug: #19922
A longer term solution should be put together that includes updating the ExternalTaskProp structure to support network modes now that ECS-A for windows allows more than bridge
All Submissions:
Adding new Unconventional Dependencies:
New Features
yarn integto deploy the infrastructure and generate the snapshot (i.e.yarn integwithout--dry-run)?By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license