Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app-delivery): fix integ test not building #2190

Merged
merged 1 commit into from
Apr 8, 2019

Conversation

jogold
Copy link
Contributor

@jogold jogold commented Apr 5, 2019

Replaced cdk.Secret by cdk.SecretValue.

Although JSII build is failing for app-delivery, the Travis build is passing. This behavior can be seen on master:
https://travis-ci.org/awslabs/aws-cdk/builds/516243105#L1591
https://travis-ci.org/awslabs/aws-cdk/builds/516223708#L1591

The same kind of issue can be seen here https://travis-ci.org/awslabs/aws-cdk/builds/514128209#L1573 where the JSII build for aws-codebuild fails but not the Travis build.

Linked to the updated version of jsii? May be worth opening a specific issue...


Pull Request Checklist

  • Testing
    • Unit test added (prefer not to modify an existing test, otherwise, it's probably a breaking change)
    • CLI change?: coordinate update of integration tests with team
    • cdk-init template change?: coordinated update of integration tests with team
  • Docs
    • jsdocs: All public APIs documented
    • README: README and/or documentation topic updated
  • Title and Description
    • Change type: title prefixed with fix, feat will appear in changelog
    • Title: use lower-case and doesn't end with a period
    • Breaking?: last paragraph: "BREAKING CHANGE: <describe what changed + link for details>"
    • Issues: Indicate issues fixed via: "Fixes #xxx" or "Closes #xxx"
  • Sensitive Modules (requires 2 PR approvers)
    • IAM Policy Document (in @aws-cdk/aws-iam)
    • EC2 Security Groups and ACLs (in @aws-cdk/aws-ec2)
    • Grant APIs (only if not based on official documentation with a reference)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.

@jogold jogold requested a review from a team as a code owner April 5, 2019 18:42
Copy link
Contributor

@eladb eladb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How are our builds not broken?

@jogold
Copy link
Contributor Author

jogold commented Apr 7, 2019

Don't know... was not able to reproduce this bug. jsii? lerna? Travis? What about the builds on master with CodeBuild, same bug?

@jogold
Copy link
Contributor Author

jogold commented Apr 7, 2019

@eladb I was able to reproduce and it seems that when there are only compilation errors (Compilation errors prevented the JSII assembly from being created) from JSII then the build (cdk-build) succeeds (the error message is displayed but the exit code is 0). When there are both compilation (Compilation errors prevented the JSII assembly from being created) and type model errors (Type model errors prevented the JSII assembly from being created) then cdk-build fails. Compilation errors without type model errors are less common and could explain why this was not seen in the builds sooner.

Could this come from the changes introduced here aws/jsii#383 where the behavior in case of compilation errors was changed?

@jogold
Copy link
Contributor Author

jogold commented Apr 8, 2019

Here's another example of a build that should be failing already here https://travis-ci.org/awslabs/aws-cdk/builds/517283134#L1395, here https://travis-ci.org/awslabs/aws-cdk/builds/517283134#L1414 and here https://travis-ci.org/awslabs/aws-cdk/builds/517283134#L1461 but utimately fails only when the first type error occurs here https://travis-ci.org/awslabs/aws-cdk/builds/517283134#L1489

@eladb
Copy link
Contributor

eladb commented Apr 8, 2019

#2200

@eladb eladb merged commit 5d52624 into aws:master Apr 8, 2019
@eladb eladb mentioned this pull request Apr 8, 2019
@jogold jogold deleted the fix-app-delivery branch April 9, 2019 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants