fix(app-delivery): fix integ test not building #2190
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced
cdk.Secret
bycdk.SecretValue
.Although JSII build is failing for
app-delivery
, the Travis build is passing. This behavior can be seen on master:https://travis-ci.org/awslabs/aws-cdk/builds/516243105#L1591
https://travis-ci.org/awslabs/aws-cdk/builds/516223708#L1591
The same kind of issue can be seen here https://travis-ci.org/awslabs/aws-cdk/builds/514128209#L1573 where the JSII build for
aws-codebuild
fails but not the Travis build.Linked to the updated version of
jsii
? May be worth opening a specific issue...Pull Request Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.