Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(aws-codebuild): Fix module name in README"@aws-cdk/@aws-codepipeline-actions" => "aws-cdk/aws-codepipeline-actions" #23309

Merged
merged 1 commit into from
Dec 10, 2022

Conversation

yuyokk
Copy link
Contributor

@yuyokk yuyokk commented Dec 10, 2022

Hi folks,

I believe there is no need in @ inside in the name of @aws-cdk/@aws-codepipeline-actions.

Please let me know if this minor change makes sense.

Thank you

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Dec 10, 2022
@gitpod-io
Copy link

gitpod-io bot commented Dec 10, 2022

@github-actions github-actions bot added the repeat-contributor [Pilot] contributed between 3-5 PRs to the CDK label Dec 10, 2022
@aws-cdk-automation aws-cdk-automation requested a review from a team December 10, 2022 18:56
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 3d02022
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@comcalvi comcalvi changed the title docs(aws-codebuild): Fix module name "@aws-cdk/@aws-codepipeline-actions" => "@aws-cdk/aws-codepipeline-actions" docs(aws-codebuild): Fix module name in README"@aws-cdk/@aws-codepipeline-actions" => "aws-cdk/aws-codepipeline-actions" Dec 10, 2022
Copy link
Contributor

@comcalvi comcalvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, looks like this was a typo. Good catch

@mergify
Copy link
Contributor

mergify bot commented Dec 10, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit b66b0ca into aws:main Dec 10, 2022
@yuyokk yuyokk deleted the fix-module-name branch December 10, 2022 21:38
brennanho pushed a commit to brennanho/aws-cdk that referenced this pull request Jan 20, 2023
…line-actions" => "aws-cdk/aws-codepipeline-actions" (aws#23309)

Hi folks,

I believe there is no need in `@` inside in the name of `@aws-cdk/@aws-codepipeline-actions`.

Please let me know if this minor change makes sense.

Thank you
----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
brennanho pushed a commit to brennanho/aws-cdk that referenced this pull request Feb 22, 2023
…line-actions" => "aws-cdk/aws-codepipeline-actions" (aws#23309)

Hi folks,

I believe there is no need in `@` inside in the name of `@aws-cdk/@aws-codepipeline-actions`.

Please let me know if this minor change makes sense.

Thank you
----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p2 repeat-contributor [Pilot] contributed between 3-5 PRs to the CDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants