chore: fix patch build #25326
Merged
chore: fix patch build #25326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The patch file that's in here is unnecessary, and in fact harmful: because the rename it applies is not necessary, it copies `undefined` values into perfectly fine types. Remove patch and add guard rails agains this.
|
|
mrgrain
approved these changes
Apr 26, 2023
|
I'm wondering that as well |
|
Haaa and now the check fails because the spec has an error at the old commit |
|
Oh it's because |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
corymhall
pushed a commit
that referenced
this pull request
May 9, 2023
The patch file that's in here is unnecessary, and in fact harmful: because the rename it applies is not necessary, it copies `undefined` values into perfectly fine types. Remove patch and add guard rails agains this. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The patch file that's in here is unnecessary, and in fact harmful: because the rename it applies is not necessary, it copies
undefinedvalues into perfectly fine types.Remove patch and add guard rails agains this.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license