-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(vpclattice-alpha): L2 Construct for Vpc Lattice #26063
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
What's keeping this PR from moving forward? The resources checklist check fails due to something unrelated. @mrgrain -- what's the news? |
The prerequisite RFC for it is still open. |
if the RFC for this feature is still open, do we want to close this PR until we've hammered out the RFC? |
Any reasons a Draft PR needs to be closed? I assume the author is still working on it. |
Hi @mrpackethead, it looks like the linked RFC has been approved and merged. Are you still planning to continue working on this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm putting this into changes requested as it is still in draft mode and hasn't been worked on in a while. Doing this won't close it immediately but it will close it after four weeks if this remains unchanged. If you are still working on it, feel free to push any changes and/or open a new PR if the bot does deem this one abandoned.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week. |
This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error. |
The pull request linter fails with the following errors:
PRs must pass status checks before we can provide a meaningful review. If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing |
Not abadonded my the requesters. Abandoned by the AWS CDK team, who set us up to fail. |
This is for RFC 502
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license