Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(stepfunctions-tasks): missing permissions for running tasks on ecs #27891

Merged
merged 10 commits into from
Feb 12, 2024
Merged

fix(stepfunctions-tasks): missing permissions for running tasks on ecs #27891

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
5212117
fix(stepfunction-tasks): missing permissions for running tasks on ecs
msambol Nov 6, 2023
ee67f9e
fix snaps
msambol Nov 9, 2023
885f0c9
add feedback from Luca
msambol Nov 9, 2023
fb37482
I guess I don't need platform?
msambol Jan 9, 2024
b3c9cdb
new snaps
msambol Jan 10, 2024
148fbf4
Merge branch 'main' into sfn-tasks-tests
msambol Jan 10, 2024
1370621
Merge branch 'main' into sfn-tasks-tests
msambol Jan 16, 2024
b8ad777
Merge branch 'main' into sfn-tasks-tests
msambol Jan 24, 2024
b170d7b
Merge branch 'main' into sfn-tasks-tests
msambol Feb 11, 2024
a9bc264
Merge branch 'main' into sfn-tasks-tests
mergify[bot] Feb 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions ...sting/framework-integ/test/aws-stepfunctions-tasks/test/ecs/eventhandler-image/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
FROM public.ecr.aws/lambda/python:3.6
EXPOSE 8000
WORKDIR /src
ADD . /src
CMD python3 index.py
FROM public.ecr.aws/docker/library/python:3.12
ADD index.py .
CMD [ "python3", "./index.py" ]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I needed --platform=x86-64 since I am building on a Mac M2.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of changing the image have you tried changing CMD:

CMD [ "index.handler" ]

and defining a handler function in index.py:

import os
import print

def handler(event, context):
    print('Hello from ECS!')
    pprint.pprint(dict(os.environ))

?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did try that but didn't spend a bunch of time on it. I can revisit.. but my thinking is, why is it a Lambda image when this is running on ECS and not in Lambda?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, thanks for clarifying.

1 change: 0 additions & 1 deletion ...testing/framework-integ/test/aws-stepfunctions-tasks/test/ecs/eventhandler-image/index.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
#!/usr/bin/python
import os
import pprint

Expand Down
19 changes: 19 additions & 0 deletions ...run-task.js.snapshot/SfnTasksEcsEc2RunTaskTestDefaultTestDeployAssert2569343D.assets.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

36 changes: 36 additions & 0 deletions ...n-task.js.snapshot/SfnTasksEcsEc2RunTaskTestDefaultTestDeployAssert2569343D.template.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 0 additions & 5 deletions ...napshot/asset.7a4895bc694ae074467753dddb9a798e58f2f5eda62bcce5833d7d356b8a1da2/Dockerfile
View file
Open in desktop

This file was deleted.

3 changes: 3 additions & 0 deletions ...napshot/asset.d87af9b5acc567118fa529d3d3b763098200a6446a5ca64aea987729efd52534/Dockerfile
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion ...58f2f5eda62bcce5833d7d356b8a1da2/index.py → ...8200a6446a5ca64aea987729efd52534/index.py
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

14 changes: 7 additions & 7 deletions ...sk.js.snapshot/aws-ecs-integ2.assets.json → ...ot/aws-sfn-tasks-ecs-run-task.assets.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading