Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cloudformation-diff): cdk diff fails on node14 #28067

Merged
merged 2 commits into from
Nov 20, 2023

Conversation

mrgrain
Copy link
Contributor

@mrgrain mrgrain commented Nov 20, 2023

Some folks are still stuck on node14. Replacing .at() with conventional array access to make it easier for them. In this particular instance there's really no benefit to the code using it.

But seriously, y'all should upgrade to a current, supported version like Node.js 18.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Some folks are still stuck on node14. Replacing `.at()` with conventional array access to make it easier for them. In this particular instance there's really no benefit to the code using it.
@aws-cdk-automation aws-cdk-automation requested a review from a team November 20, 2023 07:51
@github-actions github-actions bot added the p2 label Nov 20, 2023
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Nov 20, 2023
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@mrgrain mrgrain added pr-linter/exempt-test The PR linter will not require test changes pr-linter/exempt-integ-test The PR linter will not require integ test changes labels Nov 20, 2023
@aws-cdk-automation aws-cdk-automation dismissed their stale review November 20, 2023 07:55

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Nov 20, 2023
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 1b461ea
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

mergify bot commented Nov 20, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 15c3955 into main Nov 20, 2023
13 checks passed
@mergify mergify bot deleted the mrgrain/fix/cdk-diff-fails-on-node-14 branch November 20, 2023 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. p2 pr/needs-maintainer-review This PR needs a review from a Core Team Member pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exempt-test The PR linter will not require test changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants