fix(custom-resources): log statement exposes information prohibited by security guideline #29406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aws-cdk-automation
previously requested changes
Mar 8, 2024
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
scanlonp
reviewed
Mar 8, 2024
packages/aws-cdk-lib/custom-resources/lib/provider-framework/runtime/framework.ts
Show resolved
Hide resolved
|
This seems to be a breaking change, will wrap it with a feature flag. |
|
Changes to the hash doesn't necessarily indicate a breaking change. I would pull this PR down and run those tests with |
GavinZZ
force-pushed
the
yuanhaoz/remove_presign_url_log
branch
from
edc97f5
to
672107c
Compare
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
GavinZZ
commented
Mar 8, 2024
...yer-awscli/test/integ.awscli-layer.js.snapshot/lambda-layer-awscli-integ-stack.template.json
Show resolved
Hide resolved
GavinZZ
changed the title
GavinZZ
changed the title
aws-cdk-automation
added
the
pr/needs-maintainer-review
paulhcsun
approved these changes
Mar 8, 2024
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
1 task
mergify bot
pushed a commit
that referenced
this pull request
Sep 5, 2024
) ### Issue # (if applicable) Closes #31320 ### Reason for this change Presigned url is still logged despite a previous PR to fix it. #29406 ### Description of changes Verified that the `events:` no longer display the response url. ### Description of how you validated changes Re-run all failed integration tests ### Checklist - [ ] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
pahud
pushed a commit
to pahud/aws-cdk
that referenced
this pull request
Sep 9, 2024
…#31322) ### Issue # (if applicable) Closes aws#31320 ### Reason for this change Presigned url is still logged despite a previous PR to fix it. aws#29406 ### Description of changes Verified that the `events:` no longer display the response url. ### Description of how you validated changes Re-run all failed integration tests ### Checklist - [ ] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
xazhao
pushed a commit
to xazhao/aws-cdk
that referenced
this pull request
Sep 12, 2024
…#31322) ### Issue # (if applicable) Closes aws#31320 ### Reason for this change Presigned url is still logged despite a previous PR to fix it. aws#29406 ### Description of changes Verified that the `events:` no longer display the response url. ### Description of how you validated changes Re-run all failed integration tests ### Checklist - [ ] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
GavinZZ
added a commit
that referenced
this pull request
Sep 12, 2024
) ### Issue # (if applicable) Closes #31320 ### Reason for this change Presigned url is still logged despite a previous PR to fix it. #29406 ### Description of changes Verified that the `events:` no longer display the response url. ### Description of how you validated changes Re-run all failed integration tests ### Checklist - [ ] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue # (if applicable)
Reason for this change
Current log statement will log too much content, including response URL which may not be ideal to be logged according to AWS Security Guideline. Removing the
input eventfrom the log statement.Description of changes
Remove the log statement.
Description of how you validated changes
N/A
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license