Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(s3): publicReadAccess causes deployment failure due to access denied 403 #29632

Merged
merged 5 commits into from
May 28, 2024
Merged

fix(s3): publicReadAccess causes deployment failure due to access denied 403 #29632

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b44606a
fix(s3): publicReadAccess causes deployment failure due to access den…
GavinZZ Mar 27, 2024
c02f7f0
Merge branch 'main' into yuanhaoz/s3_allow_public_access
GavinZZ Apr 19, 2024
001137c
Merge branch 'main' into yuanhaoz/s3_allow_public_access
GavinZZ May 14, 2024
f5aea05
Update packages/aws-cdk-lib/aws-s3/test/bucket.test.ts
GavinZZ May 28, 2024
7f82cb5
Merge branch 'main' into yuanhaoz/s3_allow_public_access
mergify[bot] May 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...g/framework-integ/test/aws-cloudfront/test/integ.cloudfront-custom-s3.js.snapshot/cdk.out
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions ...ot/cloudfront-custom-s3-integ.assets.json → ...ot/cloudfront-custom-s3-stack.assets.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 6 additions & 0 deletions .../cloudfront-custom-s3-integ.template.json → .../cloudfront-custom-s3-stack.template.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,12 @@
"Bucket83908E77": {
"Type": "AWS::S3::Bucket",
"Properties": {
"PublicAccessBlockConfiguration": {
"BlockPublicAcls": false,
"BlockPublicPolicy": false,
"IgnorePublicAcls": false,
"RestrictPublicBuckets": false
},
"WebsiteConfiguration": {
"ErrorDocument": "404.html",
"IndexDocument": "index.html"
Expand Down
16 changes: 8 additions & 8 deletions ...ramework-integ/test/aws-cloudfront/test/integ.cloudfront-custom-s3.js.snapshot/integ.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

19 changes: 19 additions & 0 deletions ...-custom-s3.js.snapshot/integcloudfrontcustoms3DefaultTestDeployAssert2E08B1DA.assets.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

36 changes: 36 additions & 0 deletions ...ustom-s3.js.snapshot/integcloudfrontcustoms3DefaultTestDeployAssert2E08B1DA.template.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

89 changes: 69 additions & 20 deletions ...ework-integ/test/aws-cloudfront/test/integ.cloudfront-custom-s3.js.snapshot/manifest.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading