Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cognito): standard attr timezone unexpectedly creates custom attr #5973

Merged
merged 1 commit into from
Jan 27, 2020

Conversation

nija-at
Copy link
Contributor

@nija-at nija-at commented Jan 27, 2020

List of standard attributes -
https://docs.aws.amazon.com/cognito/latest/developerguide/user-pool-settings-attributes.html#cognito-user-pools-standard-attributes

fixes #5866


Note to reviewer: Unit test has been intentionally left out since the way this attribute is used is incomplete. Currently, the way users are using this attribute is in combination with Cfn* classes -

new cognito.CfnUserPool(this, "UserPool", {
  schema: [
    {
      name: cognito.UserPoolAttribute.EMAIL,
      attributeDataType: "String",
      required: true,
      mutable: true
    },
    {
      name: cognito.UserPoolAttribute.TIMEZONE,
      attributeDataType: "String",
      required: false,
      mutable: true
    }
  ]
});

All of this should get fixed up with the implementation of - aws/aws-cdk-rfcs#91


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@nija-at nija-at added the contribution/core This is a PR that came from AWS. label Jan 27, 2020
@nija-at nija-at self-assigned this Jan 27, 2020
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Jan 27, 2020

Thank you for contributing! Your pull request is now being automatically merged.

@mergify mergify bot merged commit acf3ffc into master Jan 27, 2020
@mergify mergify bot deleted the nija-at/cognito-fixzoneinfo branch January 27, 2020 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cognito attribute for TimeZone creates a custom attribute
4 participants