-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(lambda-nodejs): external and install modules #7870
Conversation
Add support for: * external modules: modules that should not be bundled. Defaults to 'aws-sdk'. Can be used for modules already included in a Layer. * install modules: modules that should not be bundled but included in the `node_modules` folder of the Lambda package. Those modules are installed in a [Lambda compatible Docker container](https://github.com/lambci/docker-lambda) with the right installer (`npm` or `yarn`) based on lock file detection. Closes aws#6323
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
@jogold will this PR also help us in solving errors with node built-ins? Like this one: Error: [Status 1] stdout: 🚨 /project/node_modules/bluebird/js/release/promise.js:34:12: Cannot resolve dependency 'async_hooks'
|
@orangewise Yes, it should do it with |
Awesome @jogold , appreciate your contributions a lot. |
Not ready yet, there's an issue with the parcel plugin here. Investigating. |
Nice, hope it will be available soon 👍 |
Hi @jogold I see you closed this issue. Not sure if I understand how this get's merged now ;) Will it? |
I prefer to get #7898 merged first, then I can go back to this. |
Commit Message
feat(lambda-nodejs): external and install modules (#7870)
Add support for:
Can be used for modules already included in a Layer.
node_modules
folder of the Lambda package. Those modules are installed in aLambda compatible Docker container
with the right installer (
npm
oryarn
) based on lock file detection.Closes #6323
End Commit Message
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license