Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update to latest versions of all dependencies, including jsii #897

Closed
wants to merge 1 commit into from

Conversation

rix0rrr
Copy link
Contributor

@rix0rrr rix0rrr commented Oct 11, 2018

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.

@rix0rrr rix0rrr changed the title chore: Update to latest versions of all dependencies chore: Update to latest versions of all dependencies, including jsii Oct 11, 2018
@rix0rrr
Copy link
Contributor Author

rix0rrr commented Oct 11, 2018

Hmm, I'm confused as to why my package.jsons haven't been updated :/

@eladb
Copy link
Contributor

eladb commented Oct 11, 2018

@rix0rrr how did you upgrade? If you actually want to update package.json you will need to use a tool like ncu

@rix0rrr
Copy link
Contributor Author

rix0rrr commented Oct 11, 2018

I know. Doing a proper mass upgrade actually breaks yargs, and who knows what else. I'll backtrack that, don't actually want to put in the effort right now.

@rix0rrr rix0rrr closed this Oct 11, 2018
@eladb
Copy link
Contributor

eladb commented Oct 11, 2018

But I think npm update is fine. It should just upgrade within the semantic versions (which means only package-lock files would change).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants