Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(iam): Merge multiple principals correctly #983

Merged
merged 6 commits into from
Oct 23, 2018
Merged

fix(iam): Merge multiple principals correctly #983

merged 6 commits into from
Oct 23, 2018

Commits on Oct 22, 2018

  1. fix(iam): Merge multiple principals correctly 

    When adidng multiple principals, an array of principals was created, but
IAM documents expect an object with different keys, for which values may
be arrays. This corrects the merging process so it produces valid
statements.

This restores the fix for #924 that was introduced in #916 and reverted
in #958 due to an other feature part of the same commit.
    @RomainMuller
    RomainMuller committed Oct 22, 2018
    Configuration menu
    Copy the full SHA
    c40ab79 View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2018

  1. PR comments addressed

    @RomainMuller
    RomainMuller committed Oct 23, 2018
    Configuration menu
    Copy the full SHA
    096ee9e View commit details
    Browse the repository at this point in the history

  2. Add test for behavior of 'AWS:*' principal

    @RomainMuller
    RomainMuller committed Oct 23, 2018
    Configuration menu
    Copy the full SHA
    1a06df4 View commit details
    Browse the repository at this point in the history

  3. Add test for prventing mixing of principal types

    @RomainMuller
    RomainMuller committed Oct 23, 2018
    Configuration menu
    Copy the full SHA
    537e768 View commit details
    Browse the repository at this point in the history

  4. Add error message expectations

    @RomainMuller
    RomainMuller committed Oct 23, 2018
    Configuration menu
    Copy the full SHA
    dfeb706 View commit details
    Browse the repository at this point in the history

  5. Improve test coverage

    @RomainMuller
    RomainMuller committed Oct 23, 2018
    Configuration menu
    Copy the full SHA
    8fc2442 View commit details
    Browse the repository at this point in the history