Update CloudTrail to use bucket location constraints #1013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the CloudTrail bucket creation code to work in regions other than `us-east-1` by setting a bucket configuration with a location constraint on the region. This is similar to how the S3 customizations work.
|
|
Don't forget to add an entry to the CHANGELOG.rst please.
|
LGTM. 🚢 |
danielgtaylor
added a commit
that referenced
this pull request
Nov 20, 2014
Update CloudTrail to use bucket location constraints.
thoward-godaddy
pushed a commit
to thoward-godaddy/aws-cli
that referenced
this pull request
Feb 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the CloudTrail bucket creation code to work in regions other
than
us-east-1by setting a bucket configuration with a locationconstraint on the region. This is similar to how the S3 customizations
work.
cc @kyleknap, @jamesls