Add compression for pushed files on platforms that support zlib #1534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -22,7 +22,7 @@ | |||
| from awscli.customizations.codedeploy.utils import validate_s3_location | |||
| from awscli.customizations.commands import BasicCommand | |||
| from awscli.errorhandler import ServerError, ClientError | |||
|
|
|||
There was a problem hiding this comment.
pep8: make sure there are two lines separating imports from where the code logic begins
|
Looks good. A couple of very small comments. |
JordonPhillips
force-pushed
the
compress_in_codedeploy
branch
from
4586e7c
to
1dcd076
Compare
|
👍 |
JordonPhillips
force-pushed
the
compress_in_codedeploy
branch
2 times, most recently
from
5d8f860
to
fd5b034
Compare
JordonPhillips
added
pr:needs-review
|
LGTM 🚢 |
kyleknap
added
pr:ready-to-merge
JordonPhillips
force-pushed
the
compress_in_codedeploy
branch
from
fd5b034
to
57e8527
Compare
JordonPhillips
added a commit
that referenced
this pull request
Oct 12, 2015
Add compression for pushed files on platforms that support zlib
thoward-godaddy
pushed a commit
to thoward-godaddy/aws-cli
that referenced
this pull request
Feb 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1371
The user's python must have access to the zlib module which is default on the vast majority of python installations. A small number of linux distributions may not have it by default. If they don't have it, we fall back to storage mode.