Add backcompat args for argument renames #1599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In boto/botocore#703, there were some correction made to the CamelCase->snake_case conversions. However, in the CLI, we still need to support these arguments. This fix for this is to: * Add a copy of the correct arg into the arg table with the "wrong" name. * Mark the "wrong" name entry as undocumented. There were no unit tests for this module, so I added a few. I also added some functional tests for some (but not all) the rename cases, just to ensure the end to end functionality is working as we expect.
jamesls
force-pushed
the
special-casings
branch
from
29c3a33
to
a960a2d
Compare
|
The change looks good. The only thing I am curious about is how did you audit the arguments that needed an alias? We do not want to miss any to avoid breaking changes. |
|
🚢 otherwise |
|
I linked to the gist in the original pull request: https://gist.github.com/jamesls/0d1005415d30d2f9f44a Ran it against develop, ran it against the PR branch. Looked at the diff. I suppose if we wanted to be really sure I'd write the equivalent code that uses the arg tables to verify that we didn't miss anything because of customizations renaming args. |
|
Ok I think that is fine then. I do not think customization renamings is an issue because we chose what to rename it to as |
thoward-godaddy
pushed a commit
to thoward-godaddy/aws-cli
that referenced
this pull request
Feb 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In boto/botocore#703, there were some correction made
to the CamelCase->snake_case conversions.
However, in the CLI, we still need to support these arguments.
This fix for this is to:
"wrong" name.
There were no unit tests for this module, so I added a few.
I also added some functional tests for some (but not all)
the rename cases, just to ensure the end to end functionality
is working as we expect.
cc @kyleknap @mtdowling @rayluo @JordonPhillips