Add s3 presign command #2113
Merged
Add s3 presign command #2113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That way we can still use assert_params_for_cmd for code that does not make client API calls.
This command is paired with `get-object`, so it can be used to create presigned URLs you can use to retrieve objects in S3. There's a couple of enhancements I see in the future: * `presign-post` * `presign-put` * Copying the arg table to support all the params used by `get-object`
| USAGE = "<S3Uri>" | ||
| ARG_TABLE = [{'name': 'path', | ||
| 'positional_arg': True, 'synopsis': USAGE}, | ||
| {'name': 'expires-in', 'nargs': '?', |
There was a problem hiding this comment.
Is '?' is intentional for ``nargsforexpires-in`? Seems strange that you can provide `--expires-in` without a value especially since `default` is already being set.
There was a problem hiding this comment.
Not intentional, I'll remove.
|
Looks good. Pretty straightforward. I had a couple of small questions. |
|
|
||
| class TestPresignCommand(BaseAWSCommandParamsTest): | ||
|
|
||
| maxDiff = None |
There was a problem hiding this comment.
BaseAWSCommandParamsTest already sets this, does it not carry through?
There was a problem hiding this comment.
I've gone ahead and removed this.
|
Tiny questions in addition to Kyle's, but looks good. |
|
@kyleknap @JordonPhillips feedback incorporated, let me know if I've missed anything. |
jamesls
added
pr:needs-review
|
|
Thanks. Looks good. 🚢 |
kyleknap
added
pr:ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This command is paired with
get-object, so it canbe used to create presigned URLs you can use to retrieve
objects in S3. There's a couple of enhancements I see in
the future:
presign-postpresign-putget-objectI also had to make a few misc commits to the testutils module to fix
a few bugs I encountered while working on tests for this code.
Example usage:
cc @kyleknap @JordonPhillips
Closes #462