Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow 5.1 of PyYAML #4231

Merged
merged 1 commit into from
Jun 13, 2019
Merged

Allow 5.1 of PyYAML #4231

merged 1 commit into from
Jun 13, 2019

Conversation

dstufft
Copy link
Contributor

@dstufft dstufft commented Jun 11, 2019

Closes #4230

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-io
Copy link

Codecov Report

Merging #4231 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #4231   +/-   ##
========================================
  Coverage    94.41%   94.41%           
========================================
  Files          188      188           
  Lines        14151    14151           
========================================
  Hits         13360    13360           
  Misses         791      791

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8024933...73b6ece. Read the comment docs.

@asottile
Copy link
Contributor

I've had this PR for months: #4015!

@dstufft
Copy link
Contributor Author

dstufft commented Jun 13, 2019

Yea, this is an adaption of that PR that cleans up the logic in setup.py so that it isn't dependent on the ordering of requires anymore.

@dstufft dstufft merged commit a9204b0 into aws:develop Jun 13, 2019
@dstufft dstufft deleted the pyyaml-5-1 branch June 13, 2019 17:20
@asottile
Copy link
Contributor

I'm a bit miffed, not going to lie -- that could have been a comment and an easy fix up if that truly was a blocking issue instead of ignoring my PR for months and then merging essentially an identical PR.

@CumpsD
Copy link

CumpsD commented Jul 25, 2019

Is there any way to easily get awscli to install if there is PyYAML 5.1.1 installed system wide (via Arch python-yaml dist package)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants