Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for writing aws_security_token to credentials file #5085

Closed
wants to merge 1 commit into from

Conversation

thenoid
Copy link

@thenoid thenoid commented Mar 27, 2020

*Issue #5084

Description of changes:
Adds aws_security_token to the credentials file

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@joguSD
Copy link
Contributor

joguSD commented Jul 22, 2020

This looks right, could we get a test similar to test_session_token_written_to_shared_credentials_file in testsunit/customizations/configure/test_set.py for this?

@kdaily kdaily added the needs-review This issue or pull request needs review from a core team member. label Nov 17, 2021
@stealthycoin
Copy link
Contributor

Hi @thenoid thanks for the PR. Our team just put out a recent proposal in #6828 detailing improvements to the contribution process. We are working through open PRs and have determined this PR to be in the Implementation stage (described here).

Action items would be addressing the above comment from joguSD: #5085 (comment)

We are tracking this PR here on our project board and it can be set to to the review stage once new changes are ready to be reviewed.

@stealthycoin stealthycoin added response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. and removed needs-review This issue or pull request needs review from a core team member. labels Apr 4, 2022
@nateprewitt nateprewitt changed the title Fix https://github.com/aws/aws-cli/issues/5084 Add support for writing aws_security_token to credentials file Apr 4, 2022
@tim-finnigan
Copy link
Contributor

Closing as we have not heard back regarding this PR and the request to add a test mentioned above. We can continue tracking the issue (#5084) and revisit the proposed changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community implementation response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws configure set aws_security_token is not backwards compatible with boto
6 participants