-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add no-overwrite option to s3 cp
and s3 mv
commands
#6095
Conversation
f82c4a3
to
2bda3e5
Compare
Codecov Report
@@ Coverage Diff @@
## v2 #6095 +/- ##
=======================================
Coverage 94.14% 94.15%
=======================================
Files 271 271
Lines 21550 21608 +58
=======================================
+ Hits 20288 20344 +56
- Misses 1262 1264 +2
Continue to review full report at Codecov.
|
This seems like it would be prone to race condition issues since it's just a HEAD then a write. |
@vz10 - hi! Any update on this PR? |
Any update to this PR? I in need for no-overwrite option.. thanks! |
you can't implement a no-overwrite option in S3. it's not possible to do without race conditions. |
This doesn't fix the problem but may help some people out there in specific scenarios! |
"get item, do not upload if it exists" is what is requested here, and that is trivial to implement, nobody said it needs to be atomic |
Hey everyone, thanks for this pull request and the discussion around it. We've made the decision to close this pull request, and leave the feature request open for tracking purposes. There is certainly value in the feature being requested here, but this isn't something we can really accept a pull request for, as there are implementation details that need to be handled internally. Please continue to 👍 the tracking issue (#2874), and describe your use cases for such a feature in the replies. |
Issue #, if available: #2874
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.