Add ability to immediately shutdown executor #676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switch the task queue to a priority queue and allow ShutdownThreadRequest (which originally were just the QUEUE_END_SENTINEL object) to have a more important priority in the case that a user has hit Ctrl+C.
|
LGTM 👍 |
|
@danielgtaylor Sorry about this, but there's going to be one more change coming shortly. The |
This is needed to provided FIFO semantics to the task queue for objects of the same priority. We only need to be able to preempt workers with high priority items. Otherwise everything should be in FIFO order.
|
I've updated this to use a stable priority queue. Would you mind taking another look? |
|
The new stable priority queue looks good, as do the tests. 🚢-it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch the task queue to a priority queue and allow
ShutdownThreadRequest (which originally were just the QUEUE_END_SENTINEL
object) to have a more important priority in the case that a user
has hit Ctrl+C.
This is also needed to fully fix: #657
Previously, not all the integ tests were passing. Now I can all unit/integ tests passing with this change.