Endpoint provider #7418
Merged
Endpoint provider #7418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## endpoints-2.0 #7418 +/- ##
=================================================
+ Coverage 93.71% 93.74% +0.02%
=================================================
Files 351 352 +1
Lines 36175 36486 +311
Branches 5202 5261 +59
=================================================
+ Hits 33903 34205 +302
- Misses 1648 1654 +6
- Partials 624 627 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
stealthycoin
force-pushed
the
endpoint-provider
branch
from
19887be
to
4014d5f
Compare
kyleknap
reviewed
Nov 11, 2022
There was a problem hiding this comment.
Looks fine. For this PR, we should also consider pulling in this PR: boto/botocore#2767 as it looks like it makes some standalone improvements to the tests that appear to be circled back on. We can probably just add that port as a separate commit to this PR.
Creates a new endpoint provider class which is used for endpoints 2.0 resolution. This commit also pulls in some changes that the new resolver depends on that had been made in botocore/compat and botocore/utils that had not been synced into cli v2's botocore version.
stealthycoin
force-pushed
the
endpoint-provider
branch
from
4014d5f
to
f2e76d2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulling this PR into cli v2.
boto/botocore#2737
Also pulls in: boto/botocore#2762 and boto/botocore#2767