Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional s3 sync flag to address https://github.com/aws/aws-cli/issues/599 #824

Merged
merged 1 commit into from
Jul 15, 2014

Conversation

andrew512
Copy link
Contributor

Implements an optional --exact-timestamps flag for the aws s3 sync operation. This flag provides a workaround for one of the issues described in #599: failure to synchronize same-sized files when a newer version exists in S3. With this flag set, files will be synchronized unless the local and S3 timestamps match exactly.

This is essentially an implementation of the first Proposed Solution described in #599, but implemented as an optional feature as opposed to changing default behavior:

Change the time checks to be a strict equality comparison. If the times are different, we sync. This has the issue that aws s3 sync local s3://bucket && aws s3 s3://bucket local will unnecessarily sync files. However, when we download a file, we set the mtime of the file to match the LastModified time so if you were to run aws s3 sync s3://bucket local again, it would not sync any files.

@jamesls
Copy link
Member

jamesls commented Jul 14, 2014

I think this change looks good, thanks for the contribution. I've been asked to obtain a signed CLA for this contribution. Would you mind emailing me at the address in my github profile so I can send you the CLA. Thanks.

@jamesls jamesls merged commit 6c43a77 into aws:develop Jul 15, 2014
jamesls added a commit that referenced this pull request Jul 15, 2014
@jamesls
Copy link
Member

jamesls commented Jul 15, 2014

Merged, thanks again for the contribution!

jamesls added a commit that referenced this pull request Jul 16, 2014
* release-1.3.23:
  Bumping version to 1.3.23
  Update changelog with latest changes
  EMR: changed to use regionalized buckets.
  EMR: Support installing hive-site.xml in create-cluster and install-applications commands.
  Update changelog with bugfix from boto/botocore#321
  Add #824 to the changelog
  Rename of elasticloadbalancing -> elb, updates from docteam
  Optional s3 sync flag to address timestamp issues described in #599
thoward-godaddy pushed a commit to thoward-godaddy/aws-cli that referenced this pull request Feb 12, 2022
In mustache all variables ({{name}}) are HTML escaped, which is not what we want
for the generate-event command. To force unescaped HTML, you need to use the
triple mustache: {{{name}}}
thoward-godaddy pushed a commit to thoward-godaddy/aws-cli that referenced this pull request Feb 12, 2022
…ws#1389)

Everything switched to triple mustache in aws#824 except for these two
occurrences.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A feature should be added or improved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants