Null reference initialization #1845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulbartell
reviewed
Dec 23, 2022
| @@ -22,7 +22,7 @@ list(APPEND PKCS_SOURCES | |||
| ) | |||
|
|
|||
| # CPP files are searched for supporting CI build checks that verify C++ linkage of the Fleet Provisioning library | |||
There was a problem hiding this comment.
This comment makes zero sense.
paulbartell
reviewed
Dec 23, 2022
| @@ -22,7 +22,7 @@ list(APPEND PKCS_SOURCES | |||
| ) | |||
|
|
|||
| # CPP files are searched for supporting CI build checks that verify C++ linkage of the Fleet Provisioning library | |||
| file( GLOB DEMO_SRCS "*.c*" ) | |||
| file( GLOB DEMO_SRCS "mqtt_operations.c" "*.c*" ) | |||
There was a problem hiding this comment.
We should stop using globs and just list the files for improved clarity.
|
There is still an instance of an uninitialized TransportInterface_t in mqtt_demo_subscription_manager.c. |
paulbartell
approved these changes
Dec 23, 2022
adam-scislowicz
approved these changes
Dec 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
segmentation fault on shadow demo #1843
Description of changes:
Initializes the uninitialized TransportInterface_t transport variable to prevent seg fault.
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.