Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove arbitrary HKDF info length limit #424

Merged
merged 5 commits into from
May 22, 2024

Conversation

justsmth
Copy link
Contributor

Description of changes:

  • Remove arbitrary HKDF limit on the number of info bytes.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@justsmth justsmth requested a review from a team as a code owner May 22, 2024 13:36
Copy link
Contributor

@cpu cpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the super quick turnaround! The patch looks great to me. I also switched my downstream branch to use this and was able to run through the problematic HPKE test vectors without error 👍

aws-lc-rs/src/hkdf.rs Outdated Show resolved Hide resolved
skmcgrail
skmcgrail previously approved these changes May 22, 2024
@codecov-commenter
Copy link

codecov-commenter commented May 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.67%. Comparing base (c358484) to head (fed7282).
Report is 15 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #424      +/-   ##
==========================================
- Coverage   95.80%   92.67%   -3.13%     
==========================================
  Files          61       61              
  Lines        8143     8174      +31     
  Branches        0     8174    +8174     
==========================================
- Hits         7801     7575     -226     
- Misses        342      357      +15     
- Partials        0      242     +242     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@justsmth justsmth merged commit f9f0741 into aws:main May 22, 2024
182 of 186 checks passed
@justsmth justsmth deleted the remove-hkdf-info-limit branch May 23, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants