Allow ofi_iflush without memory registration if provider does not request it #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rashikakheria
suggested changes
Mar 3, 2022
src/nccl_ofi_net.c
Outdated
| } | ||
|
|
||
| /* Issue RDMA read */ | ||
| do { | ||
| rc = fi_read(rComm->local_ep, rComm->flush_buff.host_buffer, | ||
| rComm->flush_buff.size, | ||
| fi_mr_desc(rComm->flush_buff.mr_handle), | ||
| mr_desc, |
There was a problem hiding this comment.
This is incorrect. We would need to provide MR descriptor for flush buffer rather than data buffer (passed via ofi_iflush api)
There was a problem hiding this comment.
Fixed. Please review.
|
Changes look good. Could you please merge both patches into one? We will run the PR internally to check for any other regression and update once we have test results. |
dmaryin
force-pushed
the
fix-mr-registration
branch
from
dabede9
to
c3a9b42
Compare
Thanks. Commits squashed into one. |
|
Tests completed successfully. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*Issue #, if available: #98
Parts of #81 fix were missed during work on new features. Reintroduced
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.