Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update react 18 #187

Merged
merged 6 commits into from
Apr 18, 2023
Merged

Update react 18 #187

merged 6 commits into from
Apr 18, 2023

Conversation

mendaomn
Copy link
Contributor

Description

This PR updates the project to React 18. While doing so, related dependencies have been updates as well (see Changes section bellow)

Please note:

  • @testing-library/react-hooks has been removed, as it does not support React 18, and replaced with the newly added renderHook function exported by @testing-library/react
  • CloudScape depends on react-virtual, which does not support React 18. However according to the CloudScape team this is a warning that can be ignored and will be fixed in the future

Changes

  • update to React 18
  • update CloudScape to get support for React 18
  • update @testing-library to get support for React 18
  • remove @testing-library/react-hooks as it does not support React 18

How Has This Been Tested?

  • unit test suite
  • e2e test suite on a production build
  • manually, tested most of the UI on Chrome, Firefox and Safari

PR Quality Checklist

  • I added tests to new or existing code
  • I removed hardcoded strings and used react-i18next library (useTranslation hook and/or Trans component), see an example here
  • I made sure no sensitive info gets logged at any time in the codebase (see here) (e.g. no user info or details, no stacktraces, etc.)
  • I made sure that any GitHub issue solved by this PR is correctly linked
  • I checked that infrastructure/update_infrastructure.sh runs without any error
  • I checked that npm run build builds without any error
  • I checked that clusters are listed correctly
  • I checked that a new cluster can be created (config is produced and dry run passes)
  • I checked that login and logout work as expected

In order to increase the likelihood of your contribution being accepted, please make sure you have read both the Contributing Guidelines and the Project Guidelines

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@mendaomn mendaomn merged commit 1b70c16 into main Apr 18, 2023
@mendaomn mendaomn deleted the update-react-18 branch April 18, 2023 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants