Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Upgrade Deps issues #653

Closed
agdimech opened this issue Nov 15, 2023 · 5 comments · Fixed by #701
Closed

[BUG] Upgrade Deps issues #653

agdimech opened this issue Nov 15, 2023 · 5 comments · Fixed by #701
Labels
backlog bug Something isn't working needs-triage

Comments

@agdimech
Copy link
Contributor

Describe the bug

  • No documentation on how to upgrade dpes
  • pdk upgrade invokes pnpm upgrade
  • pdk itself is not upgraded

Ref: #644

Expected Behavior

  • Adequate documentation to upgrade deps
  • pdk upgrade should invoke the projen upgrade task
  • pdk should be upgraded

Current Behavior

  • No docs
  • pnpm upgrade is invoked instead of the projen command
  • pdk is not upgraded

Reproduction Steps

NA

Possible Solution

No response

Additional Information/Context

No response

PDK version used

latest

What languages are you seeing this issue on?

Typescript, Java, Python

Environment details (OS name and version, etc.)

all

@agdimech agdimech added bug Something isn't working needs-triage labels Nov 15, 2023
@janeklb
Copy link
Contributor

janeklb commented Nov 16, 2023

From this discussion #644 (comment)

In relation to pdk itself not upgrading, do you mean your dependencies on @aws/pdk?

yes, that's correct.

@agdimech
Copy link
Contributor Author

Hi @janeklb - just tried doing an upgrade-deps and my @aws/pdk dependency was updated correctly within the monorepo. Are you able to provide some code that I can use to reproduce please?

@janeklb
Copy link
Contributor

janeklb commented Nov 27, 2023

Just tried it on the most recent version and wasn't able to reproduce, so please ignore that part of my report. Thanks 🙇🏻

Copy link

This issue is now marked as stale because it hasn't seen activity for a while. Add a comment or it will be closed soon. If you wish to exclude this issue from being marked as stale, add the "backlog" label.

@github-actions github-actions bot added the stale label Jan 29, 2024
Copy link

github-actions bot commented Feb 5, 2024

Closing this issue as it hasn't seen activity for a while. Please add a comment @mentioning a maintainer to reopen. If you wish to exclude this issue from being marked as stale, add the "backlog" label.

@github-actions github-actions bot closed this as completed Feb 5, 2024
@cogwirrel cogwirrel reopened this Feb 15, 2024
@cogwirrel cogwirrel added backlog and removed stale labels Feb 15, 2024
cogwirrel added a commit that referenced this issue Feb 15, 2024
…docs

Fix the `pdk upgrade` command to call the projen task rather than the command for the underlying
package manager.

Add upgrade-deps taks for the python and java monorepos for consistency, which spawn the "upgrade"
tasks (if present) for subprojects.

Added documentation for upgrading dependencies.

This also updates the projen version which includes a fix to ensure the python install task doesn't
upgrade dependencies: projen/projen#3321

Fixes #653
cogwirrel added a commit that referenced this issue Feb 15, 2024
…docs

Fix the `pdk upgrade` command to call the projen task rather than the command for the underlying
package manager.

Add `upgrade-deps` tasks for the Python and Java monorepos for consistency, which spawn the
"upgrade" tasks (if present) for subprojects. Also update the `upgrade-deps` task for the TypeScript
monorepo to spawn the "upgrade" task for any non-node project.

Added documentation for upgrading dependencies.

This also updates the projen version which includes a fix to ensure the python install task doesn't
upgrade dependencies: projen/projen#3321

Fixes #653
cogwirrel added a commit that referenced this issue Feb 20, 2024
…docs

Fix the `pdk upgrade` command to call the projen task rather than the command for the underlying
package manager.

Add `upgrade-deps` tasks for the Python and Java monorepos for consistency, which spawn the
"upgrade" tasks (if present) for subprojects. Also update the `upgrade-deps` task for the TypeScript
monorepo to spawn the "upgrade" task for any non-node project.

Python doesn't have an upgrade task - so we call the "install" task which updates the lockfile.

Added documentation for upgrading dependencies.

Fixes #653
cogwirrel added a commit that referenced this issue Feb 27, 2024
…docs

Fix the `pdk upgrade` command to call the projen task rather than the command for the underlying
package manager.

Add `upgrade-deps` tasks for the Python and Java monorepos for consistency, which spawn the
"upgrade" tasks (if present) for subprojects. Also update the `upgrade-deps` task for the TypeScript
monorepo to spawn the "upgrade" task for any non-node project.

Python doesn't have an upgrade task - so we call the "install" task which updates the lockfile.

Added documentation for upgrading dependencies.

Fixes #653
cogwirrel added a commit that referenced this issue Feb 27, 2024
…docs (#701)

Fix the `pdk upgrade` command to call the projen task rather than the command for the underlying
package manager.

Add `upgrade-deps` tasks for the Python and Java monorepos for consistency, which spawn the
"upgrade" tasks (if present) for subprojects. Also update the `upgrade-deps` task for the TypeScript
monorepo to spawn the "upgrade" task for any non-node project.

Python doesn't have an upgrade task - so we call the "install" task which updates the lockfile.

Added documentation for upgrading dependencies.

Fixes #653
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog bug Something isn't working needs-triage
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants