Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Add ability to customize outputSpecLocation S3 bucket for type-safe-rest-api PrepareApiSpecCustomResource #812

Closed
1 of 2 tasks
pcozzi opened this issue Jul 17, 2024 · 1 comment · Fixed by #816
Labels
feature-request New feature or request needs-triage

Comments

@pcozzi
Copy link
Contributor

pcozzi commented Jul 17, 2024

Describe the feature

Allow customization of the outputSpecLocation in type-safe-rest-api, so the PrepareApiSpecCustomResource writes to the provided bucket instead of the assets bucket.

Use Case

I am trying to deploy a type-safe-api using an environment that has read-only access to the assets s3 bucket. This deployment fails because type-safe-api tries to write the prepared specification to the assets bucket, and there's currently no good way to work around it.

Proposed Solution

Expose the outputSpecLocation as a customizable property for consumers of type-safe-rest-api. Otherwise, expose a boolean that handles the creation of a dedicated output bucket on the consumer's behalf.

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

PDK version used

0.23.30

What languages will this feature affect?

Typescript

Environment details (OS name and version, etc.)

MacOS

@pcozzi pcozzi added feature-request New feature or request needs-triage labels Jul 17, 2024
@pcozzi
Copy link
Contributor Author

pcozzi commented Jul 23, 2024

I'm starting work on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request New feature or request needs-triage
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant