Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs incorrect #359

Closed
charsleysa opened this issue Apr 11, 2018 · 2 comments
Closed

Docs incorrect #359

charsleysa opened this issue Apr 11, 2018 · 2 comments
Labels
area/docs contributors/welcome Contributors are welcome to work on this type/documentation

Comments

@charsleysa
Copy link
Contributor

The docs which cover additional debug arguments talk about setting an environment variable called DEBUGGER_ARGUMENTS. https://github.com/awslabs/aws-sam-local#passing-additional-runtime-debug-arguments

Though this does not work and in the source code it looks like it's referring to DEBUGGER_ARGS. https://github.com/awslabs/aws-sam-local/blob/develop/runtime.go#L439
@jfuss
Copy link
Contributor

jfuss commented May 8, 2018

@charsleysa Good catch. Would you be willing up update and send a PR?

@jfuss jfuss added the contributors/welcome Contributors are welcome to work on this label May 8, 2018
This was referenced May 9, 2018
Closed
Merged
@charsleysa
Copy link
Contributor Author

Closed by #399
cc @jfuss

qingchm added a commit to qingchm/aws-sam-cli that referenced this issue Sep 17, 2021
@qingchm
Sync flow for RestApi (aws#359)
4564ebe 
* RestApi sync flow

* Added api gateway v1 sync flow

* Black formatting

* Added new exception class, addressed error handling, refactored rest api sync flow

* Linting

* Avoided casting str onto None

* Addressing comments to remove redundant line

* Addressing comments to remove redundant test

* Implementation and test for http api

* Refactoring, reformatting

* Addressed review comments, added swagger body as part of the instance attributes

* Removed sync method from generic class
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/docs contributors/welcome Contributors are welcome to work on this type/documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@charsleysa @jfuss