-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a check to Build command for Docker if the --use-container flag i… #1075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Old Output:
New Output:
|
Thanks for the PR. Very useful. I made a minor refactor and also contributed unit tests to make sure this code path is exercised. I will merge the PR once the tests pass |
sanathkr
approved these changes
Apr 4, 2019
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you use the
--use-container
flag with thesam build
command but Docker isn't running you get some nasty output. You get a bunch of errors and stack traces about endpoints being inaccessible and so on. This is really confusing and takes some digging to find out what the problem is. I've been tripped up several times and wasted a bunch of time trying to figure out what went wrong.This PR adds a check to the
build
command to make sure Docker is reachable before trying to actually build the project inside of Docker. If Docker isn't reachable, it errors with a clear message indicating what the issue is. It also only tries to check for Docker when the--use-container
flag is passed.How to reproduce problem:
Run
sam build --use-container
while Docker isn't running.Description of changes:
Changes include an added 'if' statement in the
app_build.py
file. This uses the already existingContainerManager.is_docker_reachable
property to determine if SAM can reach Docker. This only checks if the--use-container
flag is passed. If it can't reach Docker, then it raises and exception.