-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfixes: stack-name
is required on deploy
#1573
Conversation
- providing non standard capabilities gives an appropriate error message - add s3 prefix to be the stack name during guided deploy
- | ||
!Ref SamCliSourceBucket |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks bit weird, should this be - !Ref SamCliSourceBucket
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it could also be !Sub "arn:aws:s3:::${SamCliSourceBucket}"
samcli/commands/_utils/options.py
Outdated
:return: | ||
""" | ||
|
||
default_stack_name = "sam-app" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit-pick: I am not sure if this is a convention we are following but at few places I have seen constants to be in all CAPS like: DEFAULT_STACK_NAME
.
@@ -50,7 +51,8 @@ | |||
@template_click_option(include_build=True) | |||
@click.option( | |||
"--stack-name", | |||
required=True, | |||
required=False, | |||
callback=guided_deploy_stack_name, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Should roll this into init too sometime, possibly.
- | ||
!Ref SamCliSourceBucket |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it could also be !Sub "arn:aws:s3:::${SamCliSourceBucket}"
* bugfixes: `stack-name` is required on deploy - providing non standard capabilities gives an appropriate error message - add s3 prefix to be the stack name during guided deploy * fix: help text on parameter overrides * fix: add `serverlessrepo` access to managed stack * fix: address comments * fix: usability fixes * fix: parameter defaults are casted to string * fix: unit tests on bootstrap
Issue #, if available:
Description of changes:
Checklist:
make pr
passesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.