Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tests): Fix local test failing for account ID checks #7161

Merged
merged 4 commits into from
Jun 13, 2024

Conversation

lucashuy
Copy link
Contributor

@lucashuy lucashuy commented Jun 12, 2024

Which issue(s) does this change fix?

None

Why is this change necessary?

A recent change made to the local command behaviour causes some of the integration tests to fail. This is due to the local integration tests never expecting there to be an actual valid account ID, however this is no longer the case.

How does it address the issue?

Checks if the account ID looks and smells like an account ID, instead of checking for an exact value.

What side effects does this change have?

Mandatory Checklist

PRs will only be reviewed after checklist is complete

  • Add input/output type hints to new functions/methods
  • Write design document if needed (Do I need to write a design document?)
  • Write/update unit tests
  • Write/update integration tests
  • Write/update functional tests if needed
  • make pr passes
  • make update-reproducible-reqs if dependencies were changed
  • Write documentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@lucashuy lucashuy requested a review from a team as a code owner June 12, 2024 18:41
@lucashuy lucashuy enabled auto-merge June 13, 2024 17:05
@lucashuy lucashuy added this pull request to the merge queue Jun 13, 2024
Merged via the queue into aws:develop with commit 6ea4b1b Jun 13, 2024
55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants